netdev - Re: [PATCHv2 net-next] add DOVE extensions for VXLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 19 Nov 2012 18:55:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dlstevens@...ibm.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next] add DOVE extensions for VXLAN

From: David L Stevens <dlstevens@...ibm.com>
Date: Thu, 15 Nov 2012 08:46:27 -0500

> @@ -111,6 +113,10 @@ struct vxlan_dev {
>  	__u8		  tos;		/* TOS override */
>  	__u8		  ttl;
>  	bool		  learn;
> +	bool		  proxy;	/* ARP reduction */
> +	bool		  rsc;		/* route short-circuit */
> +	bool		  l2miss;	/* L2 miss notifications */
> +	bool		  l3miss;	/* L3 miss notifications */
>  
>  	unsigned long	  age_interval;
>  	struct timer_list age_timer;

Perhaps we've accumulated enough boolean states that a "u32 flags" are
in order?

> +		for (i=0; i<ETH_ALEN; ++i)
> +			send_eth |= !!fdb->eth_addr[i];

Please use is_zero_ether_addr().

Otherwise these changes look fine to me, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html