lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Nov 2012 18:58:08 -0500 (EST) From: David Miller <davem@...emloft.net> To: srinivas.kandagatla@...com Cc: netdev@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org Subject: Re: [PATCH v2 3.7.0-rc4] of/net/mdio-gpio: Fix pdev->id issue when using devicetrees. From: Srinivas KANDAGATLA <srinivas.kandagatla@...com> Date: Fri, 16 Nov 2012 10:33:59 +0000 > From: Srinivas Kandagatla <srinivas.kandagatla@...com> > > When the mdio-gpio driver is probed via device trees, the platform > device id is set as -1, However the pdev->id is re-used as bus-id for > while creating mdio gpio bus. > So > For device tree case the mdio-gpio bus name appears as "gpio-ffffffff" > where as > for non-device tree case the bus name appears as "gpio-<bus-num>" > > Which means the bus_id is fixed in device tree case, so we can't have > two mdio gpio buses via device trees. Assigning a logical bus number > via device tree solves the problem and the bus name is much consistent > with non-device tree bus name. > > Without this patch > 1. we can't support two mdio-gpio buses via device trees. > 2. we should always pass gpio-ffffffff as bus name to phy_connect, very > different to non-device tree bus name. > > So, setting up the bus_id via aliases from device tree is the right > solution and other drivers do similar thing. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...com> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists