netdev - Re: smsc95xx: detect chip revision specific features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKh2mn4RQDEfeMGBLm0s1kQtf_m4naKZO0mdV07BegsURzOWFw@mail.gmail.com>
Date:	Tue, 27 Nov 2012 13:21:13 +0000
From:	Steve Glendinning <steve@...well.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: smsc95xx: detect chip revision specific features

>> > drivers/net/usb/smsc95xx.c
>> >   1283          if (pdata->wolopts & (WAKE_BCAST | WAKE_MCAST | WAKE_ARP | WAKE_UCAST)) {
>> >   1284                  u32 *filter_mask = kzalloc(32, GFP_KERNEL);
>> >                                                    ^^
>> > We allocate 8 unsigned 32 bit values.  I think this is the mistake here
>> > actually.  It is a typo and should say:

<snip>

On re-reading the datasheet we *do* need 32 u32's here so you were
right the first time!  Patch on its way shortly.

Steve
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html