netdev - Re: [PATCH v2 net-next] net: move inet_dport/inet_num in sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1354123125.14302.432.camel@edumazet-glaptop>
Date:	Wed, 28 Nov 2012 09:18:45 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, ling.ma.program@...il.com, joe@...ches.com,
	bhutchings@...arflare.com
Subject: Re: [PATCH v2 net-next] net: move inet_dport/inet_num in
 sock_common

On Wed, 2012-11-28 at 12:02 -0500, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Wed, 28 Nov 2012 11:48:35 -0500 (EST)
> 
> > I like this a lot, applied, thanks Eric!
> 
> And I'd like it even more if it was build tested :-/
> 
> net/ipv4/inet_hashtables.c: In function ‘__inet_lookup_established’:
> net/ipv4/inet_hashtables.c:242:7: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:246:8: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:267:7: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:274:8: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:226:2: warning: unused variable ‘acookie’ [-Wunused-variable]
> net/ipv4/inet_hashtables.c: In function ‘__inet_check_established’:
> net/ipv4/inet_hashtables.c:326:7: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:341:7: error: expected expression before ‘)’ token
> net/ipv4/inet_hashtables.c:307:2: warning: unused variable ‘acookie’ [-Wunused-variable]
> net/ipv4/inet_hashtables.c:306:6: warning: unused variable ‘dif’ [-Wunused-variable]
> 
> This is with gcc-4.7.2-2 on Fedora 17 on an allmodconfig build.

Hmm, sorry David, I'll double check and send a v3.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html