lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Nov 2012 18:39:36 +0100 From: Krzysztof Mazur <krzysiek@...lesie.net> To: chas williams - CONTRACTOR <chas@....nrl.navy.mil> Cc: David Woodhouse <dwmw2@...radead.org>, David Laight <David.Laight@...LAB.COM>, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, nathan@...verse.com.au Subject: Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc On Fri, Nov 30, 2012 at 12:12:56PM -0500, chas williams - CONTRACTOR wrote: > >Really, what we're saying is that *one* of the driver or protocol close > >functions needs to be split, and we need to do DPD or PDP. Since the > >device driver *can* abort/flush the TX queue and also any pending RX > >being handled by a tasklet, I think it makes most sense to keep it in > >the middle, with the protocol being handled first and last... which is > >the current order, as long as we consider setting ATM_VF_CLOSE to be the > >first part. > > i believe this is essentially already done with the release_cb() > implementation right? that is splitting the protocol detach/shutdown > into two parts. partially, release_cb() is about ATM socket locking. To avoid some races we need to take the ATM socket lock in protocol send function (br2684_start_xmit, pppoatm_send, ...). That functions are executed in bh context and we cannot sleep and wait for releasing the ATM socket lock, so we just block sending and when the ATM socket is unlocked release_cb() is called and we re-enabling sending. Currently the first part of detach is just: lock_sock(sk) (without latest "br2684: don't send frames on not-ready vcc" the first part was set_bit(ATM_VF_CLOSE, &vcc->flags); clear_bit(ATM_VF_READY, &vcc->flags); for br2684) After that the protocol stops sending new packets so the vcc may be fully closed by ATM driver. The protocol is still ready to process received packets. After vcc is closed the protocol can safely detach knowing that no new packets will be received. Krzysiek -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists