netdev - RE: [net-next 6/8] bna: Add Stats Clear Counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86B5B0B9CB7A@HQ1-EXCH01.corp.brocade.com>
Date:	Thu, 6 Dec 2012 15:23:38 -0800
From:	Rasesh Mody <rmody@...cade.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Adapter Linux Open SRC Team 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [net-next 6/8] bna: Add Stats Clear Counter

>From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>Sent: Thursday, December 06, 2012 12:55 PM
>
>On Thu, 2012-12-06 at 12:34 -0800, Rasesh Mody wrote:
>> >From: Ben Hutchings [mailto:bhutchings@...arflare.com]
>> >Sent: Wednesday, December 05, 2012 6:20 PM
>> >Subject: Re: [net-next 6/8] bna: Add Stats Clear Counter
>> >
>> >On Wed, 2012-12-05 at 15:01 -0800, Rasesh Mody wrote:
>> >> Added Stats clear counter to the bfi_enet_stats_mac structure and
>> >> ethtool stats
>> >>
>> >> Signed-off-by: Rasesh Mody <rmody@...cade.com>
>> >
>> >Since this structure appears to be part of the firmware interface,
>> >you should combine this (and any other interface changes) with the
>> >change to the requested firmware version (7/8).
>>
>> Ben,
>>
>> Thanks for the feedback. Yes, bfi_enet_stats_mac is a part of firmware
>> interface update.
>>
>> In future submission, I will plan to take care of combining such
>> firmware interface updates/changes and the firmware request version
>> change into single patch. Please let me know if you think it is
>> required for this patch set.
>
>That's not my decision.

I have resubmitted the patch set to address you feedback.

Thanks,
Rasesh