lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <50C248BD.6080803@fuel7.com> Date: Fri, 07 Dec 2012 13:51:25 -0600 From: Patrick Trantham <patrick.trantham@...l7.com> To: Cong Ding <dinggnu@...il.com> CC: "David S. Miller" <davem@...emloft.net>, Otavio Salvador <otavio@...ystems.com.br>, Javier Martinez Canillas <javier@...hile0.org>, Jiri Kosina <jkosina@...e.cz>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fix initializer entry defined twice issue On 12/06/2012 06:05 PM, Cong Ding wrote: > On Thu, Dec 06, 2012 at 05:59:21PM -0600, Patrick Trantham wrote: >> On 12/06/2012 05:16 PM, Cong Ding wrote: >>> the ".config_intr" is defined twice in both line 208 and 212. >>> >>> Signed-off-by: Cong Ding <dinggnu@...il.com> >>> --- >>> drivers/net/phy/smsc.c | 1 - >>> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c >>> index 16dceed..5cee6bd 100644 >>> --- a/drivers/net/phy/smsc.c >>> +++ b/drivers/net/phy/smsc.c >>> @@ -205,7 +205,6 @@ static struct phy_driver smsc_phy_driver[] = { >>> /* basic functions */ >>> .config_aneg = genphy_config_aneg, >>> .read_status = lan87xx_read_status, >>> - .config_intr = smsc_phy_config_intr, >>> /* IRQ related */ >>> .ack_interrupt = smsc_phy_ack_interrupt, >> Hi Cong, >> >> That looks like a mistake from my previous patch to that file. Copy >> and paste fail. >> >> The line should read: >> .config_init = smsc_phy_config_init, >> >> I can submit a patch once I get off work unless you beat me to it. > Thanks for the note. It's better that you submit a patch together with your > code. > > - cong Patch submitted, thanks for pointing this out! - Patrick -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists