netdev - Re: [net-next 1/7] bna: Code Cleanup and Enhancements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121210.171349.1368932708858713762.davem@davemloft.net>
Date:	Mon, 10 Dec 2012 17:13:49 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rmody@...cade.com
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	David.Laight@...LAB.COM, adapter_linux_open_src_team@...cade.com
Subject: Re: [net-next 1/7] bna: Code Cleanup and Enhancements

From: Rasesh Mody <rmody@...cade.com>
Date: Mon, 10 Dec 2012 13:41:59 -0800

> -		skb = unmap_array[unmap_cons].skb;
> -		BUG_ON(!(skb));
> -		unmap_array[unmap_cons].skb = NULL;
> +		curr_ua = &unmap_array[unmap_cons];
> +
> +		skb = curr_ua->skb;
> +		BUG_ON(!(skb));\
                               ^^^

Really?

Please carefully review your own work before submitting it for
inclusion.  When you have erroneous things like this in the
very first patch it reflects very poorly upon the quality of
your work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html