lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 10 Dec 2012 16:39:15 -0800
From:	Rasesh Mody <rmody@...cade.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>,
	"David.Laight@...LAB.COM" <David.Laight@...LAB.COM>,
	"Adapter Linux Open SRC Team" 
	<adapter_linux_open_src_team@...cade.COM>
Subject: RE: [net-next 1/7] bna: Code Cleanup and Enhancements

>From: David Miller [mailto:davem@...emloft.net]
>Sent: Monday, December 10, 2012 2:14 PM
>
>From: Rasesh Mody <rmody@...cade.com>
>Date: Mon, 10 Dec 2012 13:41:59 -0800
>
>> -		skb = unmap_array[unmap_cons].skb;
>> -		BUG_ON(!(skb));
>> -		unmap_array[unmap_cons].skb = NULL;
>> +		curr_ua = &unmap_array[unmap_cons];
>> +
>> +		skb = curr_ua->skb;
>> +		BUG_ON(!(skb));\
>                               ^^^
>
>Really?
>
>Please carefully review your own work before submitting it for
>inclusion.  When you have erroneous things like this in the very first
>patch it reflects very poorly upon the quality of your work.

Sorry Dave, it accidentally got introduced. I will rectify it and resend the patches after carefully reviewing patches for similar errors.

Thanks
Rasesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists