netdev - Re: sock_ioctl sleeping while atomic warning during boot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121221.131504.402952074906485532.davem@davemloft.net>
Date:	Fri, 21 Dec 2012 13:15:04 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	brian.haley@...com
Cc:	eric.dumazet@...il.com, davej@...hat.com, netdev@...r.kernel.org
Subject: Re: sock_ioctl sleeping while atomic warning during boot.

From: Brian Haley <brian.haley@...com>
Date: Thu, 20 Dec 2012 22:31:03 -0500

> On 12/20/2012 10:25 PM, Eric Dumazet wrote:
>> OK, thanks for the report.
>> 
>> We need a seqcount, not a seqlock, as RTNL already protects multiple
>> writers.
>> 
>> Please try following fix :
>> 
>> 
>> [PATCH] net: devnet_rename_seq should be a seqcount
>> 
>> Using a seqlock for devnet_rename_seq is not a good idea,
>> as device_rename() can sleep.
>> 
>> As we hold RTNL, we dont need a protection for writers,
>> and only need a seqcount so that readers can catch a change done
>> by a writer.
>> 
>> Bug added in commit c91f6df2db4972d3 (sockopt: Change getsockopt() of
>> SO_BINDTODEVICE to return an interface name)
>> 
>> Reported-by: Dave Jones <davej@...hat.com>
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Cc: Brian Haley <brian.haley@...com>
> 
> Sorry about that, thanks for the quick fix Eric.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html