netdev - Re: sock_ioctl sleeping while atomic warning during boot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50D3D7F7.2030200@hp.com>
Date:	Thu, 20 Dec 2012 22:31:03 -0500
From:	Brian Haley <brian.haley@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Dave Jones <davej@...hat.com>, netdev@...r.kernel.org
Subject: Re: sock_ioctl sleeping while atomic warning during boot.

On 12/20/2012 10:25 PM, Eric Dumazet wrote:
> OK, thanks for the report.
> 
> We need a seqcount, not a seqlock, as RTNL already protects multiple
> writers.
> 
> Please try following fix :
> 
> 
> [PATCH] net: devnet_rename_seq should be a seqcount
> 
> Using a seqlock for devnet_rename_seq is not a good idea,
> as device_rename() can sleep.
> 
> As we hold RTNL, we dont need a protection for writers,
> and only need a seqcount so that readers can catch a change done
> by a writer.
> 
> Bug added in commit c91f6df2db4972d3 (sockopt: Change getsockopt() of
> SO_BINDTODEVICE to return an interface name)
> 
> Reported-by: Dave Jones <davej@...hat.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Brian Haley <brian.haley@...com>

Sorry about that, thanks for the quick fix Eric.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html