lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 30 Dec 2012 20:06:16 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] team: update master carrier state

On Sun, Dec 30, 2012 at 10:47:23PM +0100, Jiri Pirko wrote:
> Sun, Dec 30, 2012 at 07:27:29PM CET, fbl@...hat.com wrote:
> >Update master's carrier state when there is any
> >change with its ports.
> 
> 
> This patch looks good to me. Just one nitpick I spotted....
> 
> >+	bool team_linkup;
> >+
> >+	team_linkup = false;
> 
> 
> This can be squashed together.

Ok, but that increases the static size of the module because it
moves the variable out of bss.

I have no strong opinion on either case, so it's up to you.

Thanks,
-- 
fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists