lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121230221052.GF1575@minipsycho.orion> Date: Sun, 30 Dec 2012 23:10:52 +0100 From: Jiri Pirko <jiri@...nulli.us> To: netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next] team: update master carrier state Sun, Dec 30, 2012 at 11:06:16PM CET, fbl@...hat.com wrote: >On Sun, Dec 30, 2012 at 10:47:23PM +0100, Jiri Pirko wrote: >> Sun, Dec 30, 2012 at 07:27:29PM CET, fbl@...hat.com wrote: >> >Update master's carrier state when there is any >> >change with its ports. >> >> >> This patch looks good to me. Just one nitpick I spotted.... >> >> >+ bool team_linkup; >> >+ >> >+ team_linkup = false; >> >> >> This can be squashed together. > >Ok, but that increases the static size of the module because it >moves the variable out of bss. > >I have no strong opinion on either case, so it's up to you. Ok :) Acked-by: Jiri Pirko <jiri@...nulli.us> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists