[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAD6jFUTRBcQrodQ7xydMgNyyeHz9bggvJ+tDhApfbGOfznwQMw@mail.gmail.com>
Date: Wed, 2 Jan 2013 11:47:15 +0100
From: Daniel Borkmann <danborkmann@...earbox.net>
To: David Miller <davem@...emloft.net>
Cc: eric.dumazet@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/8] Add complementary BPF conditional jump instructions
On Tue, Jan 1, 2013 at 6:18 AM, David Miller <davem@...emloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 31 Dec 2012 19:29:02 -0800
>
>> On Mon, 2012-12-31 at 14:37 -0800, David Miller wrote:
>>
>>> Whilst I agree that adding NE jumps adds great value and closes a
>>> serious gap, the rest can be synthesized by simply swapping the
>>> arguments and using a comparison that does already exist.
>>>
>>> Why isn't that sufficient?
>>
>> I am afraid none of these patches is needed at all.
>>
>> Swapping the jt/jf is plainly enough for the user land compiler.
>>
>> libcap seems to do it already
>
> Agreed.
Fair enough, it's probably better to let this be done by user space
via such a hack than adding the actual operations for this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists