netdev - Re: [patch net-next V4 00/15] net: introduce upper device lists and remove dev->master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130102.025420.1993175980232815756.davem@davemloft.net>
Date:	Wed, 02 Jan 2013 02:54:20 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, edumazet@...gle.com,
	bhutchings@...arflare.com, faisal.latif@...el.com,
	shemminger@...tta.com, fbl@...hat.com, roland@...nel.org,
	sean.hefty@...el.com, hal.rosenstock@...il.com, fubar@...ibm.com,
	andy@...yhouse.net, divy@...lsio.com, jitendra.kalsaria@...gic.com,
	sony.chacko@...gic.com, linux-driver@...gic.com, kaber@...sh.net,
	ursula.braun@...ibm.com, blaschka@...ux.vnet.ibm.com,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	ebiederm@...ssion.com, joe@...ches.com, amwang@...hat.com,
	nhorman@...driver.com, john.r.fastabend@...el.com,
	pablo@...filter.org
Subject: Re: [patch net-next V4 00/15] net: introduce upper device lists
 and remove dev->master


This patch set breaks the build:

drivers/infiniband/hw/nes/nes_cm.c: In function ‘nes_addr_resolve_neigh’:
drivers/infiniband/hw/nes/nes_cm.c:1343:3: error: implicit declaration of function ‘netdev_unique_upper_dev_get’

I could give you a hard time and say that any time you touch a core
header file you must do something at least approximating an
allmodconfig build.

But in this case, it is clear that you didn't even test the final
patch set with this specific infiniband driver enabled.

That's really disappointing.