netdev - Re: [PATCH net-next v2 2/3] netpoll: add IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1357225738.2505.4.camel@cr0>
Date:	Thu, 03 Jan 2013 23:08:58 +0800
From:	Cong Wang <amwang@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] netpoll: add IPv6 support

On Thu, 2013-01-03 at 01:54 -0800, David Miller wrote:
> From: Cong Wang <amwang@...hat.com>
> Date: Thu,  3 Jan 2013 12:50:22 +0800
> 
> > -static inline int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh,
> > -				 int proto)
> > +int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
> >  {
> >  	int err;
> >  
> > -- 
> > 1.7.7.6
> > 
> 
> With IPV6=m and NETPOLL=y using this symbol will not work.
> 

Good point!

One solution is to introduce a new Kconfig option:

+config NETPOLL6
+       depends on (IPV6 || IPV6=n)
+       def_bool NETPOLL
+

and move these IPV6 code under #ifdef CONFIG_NETPOLL6.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html