netdev - Re: [RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130103074503.3bafe61a@nehalam.linuxnetplumber.net>
Date:	Thu, 3 Jan 2013 07:45:03 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Rami Rosen <ramirose@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS_LOCAL from
 vxlan device features.

On Thu,  3 Jan 2013 11:25:21 +0200
Rami Rosen <ramirose@...il.com> wrote:

> There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.
> 
> Signed-off-by: Rami Rosen <ramirose@...il.com>
> ---
>  drivers/net/vxlan.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 40f2cc1..385f743 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1185,7 +1185,6 @@ static void vxlan_setup(struct net_device *dev)
>  
>  	dev->tx_queue_len = 0;
>  	dev->features	|= NETIF_F_LLTX;
> -	dev->features	|= NETIF_F_NETNS_LOCAL;
>  	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
>  	dev->features   |= NETIF_F_RXCSUM;
>  

Vxlan works over UDP socket, and the UDP socket is part of the namespace
it is created in. Moving the vxlan device does not move that state.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html