netdev - Re: [PATCH 3/4] DSA: Convert printk calls to netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357239972.5452.5.camel@joe-AO722>
Date:	Thu, 03 Jan 2013 11:06:12 -0800
From:	Joe Perches <joe@...ches.com>
To:	Barry Grussling <barry@...ssling.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/4] DSA: Convert printk calls to netdev_info calls

On Wed, 2013-01-02 at 17:54 -0800, Barry Grussling wrote:
> Convert DSA printk calls to netdev_info calls as recommended by
> checkpatch.pl.

Some defects here.

> diff --git a/drivers/net/dsa/mv88e6060.c b/drivers/net/dsa/mv88e6060.c
[]
> @@ -237,7 +237,7 @@ static void mv88e6060_poll_link(struct dsa_switch *ds)
>  
>  		if (!link) {
>  			if (netif_carrier_ok(dev)) {
> -				printk(KERN_INFO "%s: link down\n", dev->name);
> +				netdev_info(dev, "%s: link down\n", dev->name);

Take out the "%s: ...", dev->name uses in these
conversions because netdev_printk adds them.

				netdev_info(dev, "link down\n");

> @@ -248,7 +248,7 @@ static void mv88e6060_poll_link(struct dsa_switch *ds)
>  		fc = ((port_status & 0xc000) == 0xc000) ? 1 : 0;
>  
>  		if (!netif_carrier_ok(dev)) {
> -			printk(KERN_INFO "%s: link up, %d Mb/s, %s duplex, "
> +			netdev_info(dev, "%s: link up, %d Mb/s, %s duplex, "
>  					 "flow control %sabled\n", dev->name,
>  					 speed, duplex ? "full" : "half",
>  					 fc ? "en" : "dis");

coalesce formats too

			netdev_info(dev, "link up, %d Mb/s, %s duplex, flow control %sabled\n"
				    speed, duplex ? "full" : "half",
				    fc ? "en" : "dis");
etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html