netdev - Re: [PATCH 2/4] DSA: Convert msleep calls to usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1357244056.2685.7.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Thu, 3 Jan 2013 20:14:16 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Barry Grussling <barry@...ssling.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4] DSA: Convert msleep calls to usleep_range calls

On Wed, 2013-01-02 at 17:54 -0800, Barry Grussling wrote:
> Convert DSA msleep calls to usleep_range calls as reported by
> checkpatch.pl.
> 
> Values of sleep duration were verified on Marvell hardware
> platform and appear to work.  Values chosen are not special
> and no strong "vetting" has gone into them other than verifying
> correct operation on available hardware.
[...]

I seriously doubt that it is worth the trouble to save wake-ups during
the occasional hardware reset.  And using usleep_range() 1000 times is
weird.  If the sleep duration can vary then the right thing to do is
probably to calculate a deadline first (jiffies + HZ) and then sleep
repeatedly until the deadline is in the past.  This also accounts for
the fact that HZ may be < 1000...

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html