netdev - Re: [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rxknwzwvrZZp5++10-ZLLjUf2TMuO7d7vzxqJM2nxtckA@mail.gmail.com>
Date:	Tue, 8 Jan 2013 06:51:13 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com, joe@...ches.com
Subject: Re: [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus

2013/1/8 David Miller <davem@...emloft.net>:
> From: Rafał Miłecki <zajec5@...il.com>
> Date: Sun,  6 Jan 2013 01:20:09 +0100
>
>> V4: stop queue when ring is full
>
> You're still not doing it right.
>
>> +     if (free_slots == 1) { /* Should never happen (netif_stop_queue) */
>> +             bgmac_err(bgmac, "TX after stopping queue!\n");
>> +             return NETDEV_TX_BUSY;
>> +     }
>
> You need to call netif_stop_queue() in this code path too.

In case of (free_slots == 1) the queue should already be stopped by
the previous xmit call (at the end). I didn't know it make sens to try
stopping it again.


> Look more carefully at the drivers we asked you to use as
> a model, they all do this properly.

Sorry, I obviously have problems understanding that :| I thought it's
enough to stop the queue at the end of xmit.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html