netdev - Re: [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130107.222152.1296444483411794560.davem@davemloft.net>
Date:	Mon, 07 Jan 2013 22:21:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	zajec5@...il.com
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com, joe@...ches.com
Subject: Re: [PATCH V4] bgmac: driver for GBit MAC core on BCMA bus

From: Rafa┅ Mi┅ecki <zajec5@...il.com>
Date: Tue, 8 Jan 2013 06:51:13 +0100

> 2013/1/8 David Miller <davem@...emloft.net>:
>> From: Rafa┅ Mi┅ecki <zajec5@...il.com>
>> Date: Sun,  6 Jan 2013 01:20:09 +0100
>>
>>> V4: stop queue when ring is full
>>
>> You're still not doing it right.
>>
>>> +     if (free_slots == 1) { /* Should never happen (netif_stop_queue) */
>>> +             bgmac_err(bgmac, "TX after stopping queue!\n");
>>> +             return NETDEV_TX_BUSY;
>>> +     }
>>
>> You need to call netif_stop_queue() in this code path too.
> 
> In case of (free_slots == 1) the queue should already be stopped by
> the previous xmit call (at the end). I didn't know it make sens to try
> stopping it again.

It obviously is not stopped, otherwise this function wouldn't get
called.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html