netdev - Re: [Patch net-next v3] netpoll: fix a rtnl lock assertion failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130114.181350.1796205610296377637.davem@davemloft.net>
Date:	Mon, 14 Jan 2013 18:13:50 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	amwang@...hat.com, netdev@...r.kernel.org, jiri@...nulli.us
Subject: Re: [Patch net-next v3] netpoll: fix a rtnl lock assertion failure

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 14 Jan 2013 09:09:56 -0800

> On Mon, 2013-01-14 at 09:07 -0800, Eric Dumazet wrote:
> 
>> Strange, why dont we call netdev_master_upper_dev_get() instead ?
>> 
>> 
> 
> What I meant is : the result of this check might be of little use, if we
> don't hold any lock preventing another thread to change things behind
> us.

Agreed, this test is going to be racey.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html