netdev - Re: [PATCH 2/2] e1000e: display a warning message when SmartSpeed works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1358370969.6408.11.camel@jtkirshe-mobl>
Date:	Wed, 16 Jan 2013 13:16:09 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	Koki Sanagi <sanagi.koki@...fujitsu.com>, netdev@...r.kernel.org,
	davem@...emloft.net, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, gregory.v.rose@...el.com,
	peter.p.waskiewicz.jr@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, tushar.n.dave@...el.com,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] e1000e: display a warning message when SmartSpeed
 works

On Wed, 2013-01-16 at 13:59 +0100, Bjørn Mork wrote:
> Koki Sanagi <sanagi.koki@...fujitsu.com> writes:
> 
> > +			if (phy->speed_downgraded)
> > +				netdev_warn(netdev, "Link Speed was "
> > +					"downgraded by SmartSpeed\n");
> > +
> 
> Could you please avoid breaking the string both here and in the igb
> patch?  This breaks the ability to grep for the warning.
> 
> Quoting Documentation/CodingStyle, Chapter 2:
> "However, never break user-visible strings such as printk messages,
>  because that breaks the ability to grep for them."
> 
> 
> Bjørn

I have fixed both patches that are in my queue, since the original
patches generated checkpatch.pl warnings on the strings being on 2
lines.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)