netdev - Re: [PATCH 2/2] e1000e: display a warning message when SmartSpeed works

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sj61gu6j.fsf@nemi.mork.no>
Date:	Wed, 16 Jan 2013 13:59:32 +0100
From:	Bjørn Mork <bjorn@...k.no>
To:	Koki Sanagi <sanagi.koki@...fujitsu.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	bruce.w.allan@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, gregory.v.rose@...el.com,
	peter.p.waskiewicz.jr@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, tushar.n.dave@...el.com,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] e1000e: display a warning message when SmartSpeed works

Koki Sanagi <sanagi.koki@...fujitsu.com> writes:

> +			if (phy->speed_downgraded)
> +				netdev_warn(netdev, "Link Speed was "
> +					"downgraded by SmartSpeed\n");
> +

Could you please avoid breaking the string both here and in the igb
patch?  This breaks the ability to grep for the warning.

Quoting Documentation/CodingStyle, Chapter 2:
"However, never break user-visible strings such as printk messages,
 because that breaks the ability to grep for them."


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html