netdev - Re: [RFC(v2) net-next 09/13] ipv6: Do not depend on rt->n in rt6_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50F64E83.3000200@gmail.com>
Date:	Wed, 16 Jan 2013 14:53:55 +0800
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
CC:	netdev@...r.kernel.org
Subject: Re: [RFC(v2) net-next 09/13] ipv6: Do not depend on rt->n in rt6_check_neigh().

On 01/16/2013 12:46 AM, YOSHIFUJI Hideaki wrote:
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> ---
>   net/ipv6/route.c |   15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index e16a483..ffdc8a6 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@ -552,20 +552,25 @@ static inline bool rt6_check_neigh(struct rt6_info *rt)
>   	struct neighbour *neigh;
>   	bool ret = false;
>   
> -	neigh = rt->n;
>   	if (rt->rt6i_flags & RTF_NONEXTHOP ||
> -	    !(rt->rt6i_flags & RTF_GATEWAY))
> +	    !(rt->rt6i_flags & RTF_GATEWAY)) {
>   		ret = true;
> -	else if (neigh) {
> -		read_lock_bh(&neigh->lock);
> +		goto out;
> +	}

Just return true here...

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html