netdev - RE: [net-next 04/14] e1000e: add support for IEEE-1588 PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <804857E1F29AAC47BF68C404FC60A1843ABB7F00@ORSMSX102.amr.corp.intel.com>
Date:	Fri, 18 Jan 2013 01:13:30 +0000
From:	"Allan, Bruce W" <bruce.w.allan@...el.com>
To:	Stephen Hemminger <stephen@...workplumber.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: RE: [net-next 04/14] e1000e: add support for IEEE-1588 PTP

> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> Sent: Thursday, January 17, 2013 7:56 AM
> To: Kirsher, Jeffrey T
> Cc: davem@...emloft.net; Allan, Bruce W; netdev@...r.kernel.org;
> gospo@...hat.com; sassmann@...hat.com; Richard Cochran
> Subject: Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP
> 
> On Thu, 17 Jan 2013 03:35:09 -0800
> Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> 
> > +static struct ptp_clock_info e1000e_ptp_clock_info = {
> 
> Should be static const since it is immutable and contains function pointers.

Nice catch!  Thanks for the review Stephen.  I'll submit a follow-on patch to change this
if that is alright with you.  Btw, did you catch that through inspection or did you use a
static analysis tool?

Bruce.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html