netdev - Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1358490455.23148.14.camel@jtkirshe-mobl>
Date:	Thu, 17 Jan 2013 22:27:35 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	"Allan, Bruce W" <bruce.w.allan@...el.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP

On Thu, 2013-01-17 at 17:13 -0800, Allan, Bruce W wrote:
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@...workplumber.org]
> > Sent: Thursday, January 17, 2013 7:56 AM
> > To: Kirsher, Jeffrey T
> > Cc: davem@...emloft.net; Allan, Bruce W; netdev@...r.kernel.org;
> > gospo@...hat.com; sassmann@...hat.com; Richard Cochran
> > Subject: Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP
> > 
> > On Thu, 17 Jan 2013 03:35:09 -0800
> > Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:
> > 
> > > +static struct ptp_clock_info e1000e_ptp_clock_info = {
> > 
> > Should be static const since it is immutable and contains function pointers.
> 
> Nice catch!  Thanks for the review Stephen.  I'll submit a follow-on patch to change this
> if that is alright with you.  Btw, did you catch that through inspection or did you use a
> static analysis tool?
> 
> Bruce.

Bruce-

I have to make some other changes in the series of patches, so we can
just fix up this patch for when I re-submit the series of patches.

Cheers,
Jeff

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)