netdev - Re: surprising memory request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1358687194.24121.165.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 20 Jan 2013 13:06:34 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Woodhouse <dwmw2@...radead.org>
CC:	Eric Dumazet <eric.dumazet@...il.com>,
	Dirk Hohndel <dirk@...ndel.org>,
	Jason Wang <jasowang@...hat.com>, <netdev@...r.kernel.org>
Subject: Re: surprising memory request

On Fri, 2013-01-18 at 17:59 +0000, David Woodhouse wrote:
> On Fri, 2013-01-18 at 09:46 -0800, Eric Dumazet wrote:
> > 
> > #define MAX_TAP_QUEUES 1024
> > 
> > Thats crazy if your machine has say 8 cpus.
> 
> Even crazier if your userspace is never going to *use* MQ. Can't we
> default to one queue unless userspace explicitly requests more?

I don't know about tun's internal TX queue structures but the core TX
queue structures immediately follow struct net_device and you have to
set a maximum when allocating it.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html