netdev - Re: [PATCH net-next 05/11] net/mlx4_en: Fix vlan mask for ethtool steering rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359566417.2789.17.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Wed, 30 Jan 2013 17:20:17 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amir Vadai <amirv@...lanox.com>,
	Alexander Duyck <alexander.h.duyck@...el.com>
CC:	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Hadar Hen Zion <hadarh@...lanox.com>
Subject: Re: [PATCH net-next 05/11] net/mlx4_en: Fix vlan mask for ethtool
 steering rules

On Wed, 2013-01-30 at 12:34 +0200, Amir Vadai wrote:
> From: Hadar Hen Zion <hadarh@...lanox.com>
> 
> The vlan mask field should be validated and assigned according to the field
> size which is 12 bits.
[...]

My understanding is that ethtool_flow_ext::vlan_tci corresponds to the
whole VLAN tag; a filter rule that matches only the VID must have a mask
of htons(0xfff).

The original implementation of this extension was in ixgbe and it's now
unclear to me whether it's programming hardware filters to match just
the VID or the whole VLAN tag.  Alexander, can you answer this?

I was thinking about adding new keywords to ethtool -U ('vid', 'vtag'?)
to make it easier to specify just the VID and clearer when you're
specifying the full tag.  (The 'vlan' keyword would have to remain but
could be removed from documentation.)  But if no-one really implements
matching of the full tag then maybe we can pretend those 4 bits don't
exist.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html