netdev - Re: [PATCH net-next 09/11] net/mlx4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130130.202307.2012762623231158868.davem@davemloft.net>
Date:	Wed, 30 Jan 2013 20:23:07 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, shanim@...lanox.com
Subject: Re: [PATCH net-next 09/11] net/mlx4_en: Add debugfs support

From: Amir Vadai <amirv@...lanox.com>
Date: Wed, 30 Jan 2013 12:34:25 +0200

> Add debugfs support to the mlx4_en driver such that users have the ability to access
> kernel information which can be used by external tools e.g HW monitoring ones
> 
> The filesystem is set up in the following driver/interface hierarchy:
> <debugfs>

Sigh...

This is a chronic problem.

Every time some driver developer can't figure out a way, using existing
well structured interfaces, to expose some information or statistic,
they just throw their hands in the air and add some debugfs turd.

Don't do this.

Instead, use or extend existing, well structured and typed, interfaces
to export your information.

That way every driver can export similar information in a familiar way
rather than with yet-another-debugfs-hack.

I'm not applying this series, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html