netdev - Re: [net-next 02/13] ixgbe: Adding Tx encapsulation capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5109C1FC.5010704@gmail.com>
Date:	Wed, 30 Jan 2013 16:59:40 -0800
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Alexander Duyck <alexander.h.duyck@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	davem@...emloft.net,
	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net-next 02/13] ixgbe: Adding Tx encapsulation capability

On 01/30/2013 09:48 AM, Eric Dumazet wrote:
> On Wed, 2013-01-30 at 08:58 -0800, Alexander Duyck wrote:
>> NAK, this is not a production patch.  This was just meant to be proof of
>> concept code.
> Well, this was the most interesting part of this serie for me ;)
>
> What is missing to reach production level ?

Well this was sort of a hack in the first place.  I am just treating the
outer headers as one giant L2 header in order to allow this to work.

> hw_enc_features is in net-next with no user yet, I was eager to see
> the first implementation...
>
> if (skb->encapsulation)
> 	features &= dev->hw_enc_features;

Really the feature was meant for the next gen hardware, not the current
gen.  The fact is you can apply this patch and test with it, but you
could probably do the same hack on most network drivers in order to make
them capable of doing the transmit checksum on the inner header for
VXlan frames.

The other issue is this patch was pretty much just meant to allow
testing the feature to make sure it was setup correctly in the kernel
and as such I had advised our testers to only focus on bugs in the
kernel enablement code and not the code enabling the offload in ixgbe.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html