netdev - Re: [PATCH net] tcp: Update MIB counters for drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1359588675.30177.15.camel@edumazet-glaptop>
Date:	Wed, 30 Jan 2013 15:31:15 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vijay Subramanian <subramanian.vijay@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	niveditasinghvi@...il.com
Subject: Re: [PATCH net] tcp: Update MIB counters for drops

On Wed, 2013-01-30 at 14:57 -0800, Vijay Subramanian wrote:
> This patch updates LINUX_MIB_LISTENDROPS and LINUX_MIB_LISTENOVERFLOWS in
> tcp_v4_conn_request() and tcp_v4_err(). tcp_v4_conn_request() in particular can
> drop SYNs for various reasons which are not currently tracked.
> 
> Signed-off-by: Vijay Subramanian <subramanian.vijay@...il.com>
> ---
> Ignored "line over 80 chars" warning for readability.
> 
>  net/ipv4/tcp_ipv4.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)


>  	case TCP_SYN_SENT:
> @@ -1491,8 +1492,10 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
>  	 */
>  	if (inet_csk_reqsk_queue_is_full(sk) && !isn) {
>  		want_cookie = tcp_syn_flood_action(sk, skb, "TCP");
> -		if (!want_cookie)
> +		if (!want_cookie) {
> +			NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
>  			goto drop;
> +		}

This should be done in tcp_syn_flood_action() for IPv4/IPv6
factorization.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html