netdev - Re: [PATCH net] tcp: Update MIB counters for drops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Jan 2013 18:16:21 -0800
From:	Vijay Subramanian <subramanian.vijay@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	niveditasinghvi@...il.com
Subject: Re: [PATCH net] tcp: Update MIB counters for drops

>
>
>>       case TCP_SYN_SENT:
>> @@ -1491,8 +1492,10 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
>>        */
>>       if (inet_csk_reqsk_queue_is_full(sk) && !isn) {
>>               want_cookie = tcp_syn_flood_action(sk, skb, "TCP");
>> -             if (!want_cookie)
>> +             if (!want_cookie) {
>> +                     NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
>>                       goto drop;
>> +             }
>
> This should be done in tcp_syn_flood_action() for IPv4/IPv6
> factorization.
>

Thanks Eric. In fact, tcp_syn_flood_action() already has
                NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPREQQFULLDROP);

which is the right thing to do instead of incrementing LISTENOVERFLOWS
since it is syn table that is overflowing and
not accept_queue.

I will send V2 with this fixed.

Vijay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html