netdev - RE: [PATCH] net: remove redundant checking for sock timer state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B712D@saturn3.aculab.com>
Date:	Fri, 1 Feb 2013 09:26:58 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Eric Dumazet" <eric.dumazet@...il.com>,
	"Xue Ying" <ying.xue0@...il.com>
Cc:	"David Miller" <davem@...emloft.net>, <ying.xue@...driver.com>,
	<netdev@...r.kernel.org>
Subject: RE: [PATCH] net: remove redundant checking for sock timer state

> I said that the old construct :
> 
> if (timer_pending(X))
>     del_timer(X);
> 
> could be changed to
> 
> del_timer(X);

If timer_pending() is an inline function then the additional check
might be beneficial in very hot paths.

	David