netdev - RE: [PATCH] net: remove redundant checking for sock timer state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1359732158.30177.46.camel@edumazet-glaptop>
Date:	Fri, 01 Feb 2013 07:22:38 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Laight <David.Laight@...LAB.COM>
Cc:	Xue Ying <ying.xue0@...il.com>, David Miller <davem@...emloft.net>,
	ying.xue@...driver.com, netdev@...r.kernel.org
Subject: RE: [PATCH] net: remove redundant checking for sock timer state

On Fri, 2013-02-01 at 09:26 +0000, David Laight wrote:

> If timer_pending() is an inline function then the additional check
> might be beneficial in very hot paths.

The 'If' word you use show you didn't even read the code, and you
are talking to linux netdev mailing list. We already know these things.

So what are these very hot paths you identified ?

If this was a real concern, the right thing to do is to have a generic
helper so that its real clear and self documented.

BTW sk_stop_timer() could be inlined.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html