netdev - Re: [PATCH 1/1] net: fec: fix miss init spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130204.002410.508273179967651174.davem@davemloft.net>
Date:	Mon, 04 Feb 2013 00:24:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	lznuaa@...il.com
Cc:	Frank.Li@...escale.com, linux-arm-kernel@...ts.infradead.org,
	netdev@...r.kernel.org, shawn.guo@...aro.org, B38611@...escale.com,
	s.hauer@...gutronix.de
Subject: Re: [PATCH 1/1] net: fec: fix miss init spinlock

From: Frank Li <lznuaa@...il.com>
Date: Mon, 4 Feb 2013 10:22:23 +0800

> 2013/2/3 David Miller <davem@...emloft.net>:
>> From: Frank Li <Frank.Li@...escale.com>
>> Date: Fri, 1 Feb 2013 16:56:26 +0800
>>
>>> @@ -1607,6 +1607,7 @@ static int fec_enet_init(struct net_device *ndev)
>>>       }
>>>
>>>       spin_lock_init(&fep->hw_lock);
>>> +     spin_lock_init(&fep->tmreg_lock);
>>
>> This breaks the build, tmreg_lock is only present in certain
>> configurations.
> 
> No, FEC have changed to check dramatically instead of static config.
> You can look fec.h.  tmreg_lock is always defined.

Not in the 'net' tree or you don't want this bug fixed there at all?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html