netdev - Re: [PATCH net-next 1/2] net: reset mac header in dev_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130206.155956.1647821975614860446.davem@davemloft.net>
Date:	Wed, 06 Feb 2013 15:59:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, greearb@...delatech.com
Subject: Re: [PATCH net-next 1/2] net: reset mac header in dev_start_xmit()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 05 Feb 2013 22:22:20 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> On 64 bit arches :
> 
> There is a off-by-one error in qdisc_pkt_len_init() because
> mac_header is not set in xmit path.
> 
> skb_mac_header() returns an out of bound value that was
> harmless because hdr_len is an 'unsigned int'
> 
> On 32bit arches, the error is abysmal.
> 
> This patch is also a prereq for "macvlan: add multicast filter"
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html