netdev - Re: [PATCH net-next 1/2] net: reset mac header in dev_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5111FAEC.2020203@candelatech.com>
Date:	Tue, 05 Feb 2013 22:40:44 -0800
From:	Ben Greear <greearb@...delatech.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: reset mac header in dev_start_xmit()

On 02/05/2013 10:22 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> On 64 bit arches :
>
> There is a off-by-one error in qdisc_pkt_len_init() because
> mac_header is not set in xmit path.
>
> skb_mac_header() returns an out of bound value that was
> harmless because hdr_len is an 'unsigned int'
>
> On 32bit arches, the error is abysmal.
>
> This patch is also a prereq for "macvlan: add multicast filter"

I'll go ahead and apply this one to our tree for testing, and will
apply the multicast one as soon as I resolve some bugs that currently
have me swamped...

Thanks,
Ben

-- 
Ben Greear <greearb@...delatech.com>
Candela Technologies Inc  http://www.candelatech.com

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html