netdev - Re: [PATCH] tcp: frto should not set snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130206212104.GX8912@reaktio.net>
Date:	Wed, 6 Feb 2013 23:21:04 +0200
From:	Pasi Kärkkäinen <pasik@....fi>
To:	David Miller <davem@...emloft.net>
Cc:	ncardwell@...gle.com, ilpo.jarvinen@...sinki.fi,
	eric.dumazet@...il.com, hannes@...essinduktion.org,
	stephen@...workplumber.org, netdev@...r.kernel.org,
	ycheng@...gle.com
Subject: Re: [PATCH] tcp: frto should not set snd_cwnd to 0

On Wed, Feb 06, 2013 at 04:19:19PM -0500, David Miller wrote:
> From: Pasi Kärkkäinen <pasik@....fi>
> Date: Wed, 6 Feb 2013 23:13:43 +0200
> 
> > On Wed, Feb 06, 2013 at 03:55:04PM -0500, David Miller wrote:
> >> From: Neal Cardwell <ncardwell@...gle.com>
> >> Date: Tue, 5 Feb 2013 14:49:04 -0500
> >> 
> >> > On Mon, Feb 4, 2013 at 7:14 AM, Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> wrote:
> >> >> [PATCH 1/1] tcp: fix for zero packets_in_flight was too broad
> >> >>
> >> >> There are transients during normal FRTO procedure during which
> >> >> the packets_in_flight can go to zero between write_queue state
> >> >> updates and firing the resulting segments out. As FRTO processing
> >> >> occurs during that window the check must be more precise to
> >> >> not match "spuriously" :-). More specificly, e.g., when
> >> >> packets_in_flight is zero but FLAG_DATA_ACKED is true the problematic
> >> >> branch that set cwnd into zero would not be taken and new segments
> >> >> might be sent out later.
> >> >>
> >> >> Only compile tested.
> >> >>
> >> >> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> >>  ...
> >> > Acked-by: Neal Cardwell <ncardwell@...gle.com>
> >> 
> >> Applied, thanks everyone.
> >>
> > 
> > Hmm.. are we missing CC stable@...nel.org in these patches? 
> > I guess 3.6.x is already EOL, but it'd be nice to get this bug fixed also in 3.7.x ..
> 
> We never CC: stable on networking patches, I queue them up manually
> and submit them at a time of my own choosing.
>

OK, I didn't know that. Thanks :)

-- Pasi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html