netdev - Re: [PATCH] l2tp: dont play with skb->truesize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130208.015045.564376676195476016.davem@davemloft.net>
Date:	Fri, 08 Feb 2013 01:50:46 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, jchapman@...alix.com, bircoph@...il.com
Subject: Re: [PATCH] l2tp: dont play with skb->truesize

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 07 Feb 2013 16:00:34 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Andrew Savchenko reported a DNS failure and we diagnosed that
> some UDP sockets were unable to send more packets because their
> sk_wmem_alloc was corrupted after a while (tx_queue column in
> following trace)
 ...
> Playing with skb->truesize is tricky, especially when
> skb is attached to a socket, as we can fool memory charging.
> 
> Just remove this code, its not worth trying to be ultra
> precise in xmit path.
> 
> Reported-by: Andrew Savchenko <bircoph@...il.com>
> Tested-by: Andrew Savchenko <bircoph@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html