lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130208.015245.1813436587925276241.davem@davemloft.net>
Date:	Fri, 08 Feb 2013 01:52:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dev@...xeye.de
Cc:	netdev@...r.kernel.org, cpuwolf@...il.com
Subject: Re: [PATCH] net: usb: fix regression from
 6509141f9c2ba74df6cc72ec35cd1865276ae3a4

From: Lucas Stach <dev@...xeye.de>
Date: Fri,  8 Feb 2013 03:18:39 +0100

> The newly added flag NOARP was using an already defined value, which
> broke drivers using flag MULTI_PACKET.
> 
> Signed-off-by: Lucas Stach <dev@...xeye.de>

Applied, but I reworked your commit message like so:

    net: usb: fix regression from FLAG_NOARP code
    
    In commit 6509141f9c2ba74df6cc72ec35cd1865276ae3a4 ("usbnet: add new
    flag FLAG_NOARP for usb net devices"), the newly added flag NOARP was
    using an already defined value, which broke drivers using flag
    MULTI_PACKET.
    
    Signed-off-by: Lucas Stach <dev@...xeye.de>
    Signed-off-by: David S. Miller <davem@...emloft.net>

References to commit IDs are ambiguous because a change can go
into multiple GIT trees.  Therefore we don't reference them in
commit header lines, and when we reference them in the commit
body we postfix them with the commit header line of the
referenced commit (in parenthesis and quotes) in order to
eliminate the ambiguity.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ