netdev - Re: [PATCH] bridge: set priority of STP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1360623345.20362.26.camel@edumazet-glaptop>
Date:	Mon, 11 Feb 2013 14:55:45 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] bridge: set priority of STP packets

On Mon, 2013-02-11 at 10:22 -0800, Stephen Hemminger wrote:
> Spanning Tree Protocol packets should have always been marked as
> control packets, this causes them to get queued in the high prirority
> FIFO. As Radia Perlman mentioned in her LCA talk, STP dies if bridge
> gets overloaded and can't communicate. This is a long-standing bug back
> to the first versions of Linux bridge.
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> ---
> Please consider adding to  stable as well.
> 
> --- a/net/bridge/br_stp_bpdu.c	2013-01-16 09:47:00.599539375 -0800
> +++ b/net/bridge/br_stp_bpdu.c	2013-02-11 08:13:56.315979316 -0800
> @@ -16,6 +16,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/llc.h>
>  #include <linux/slab.h>
> +#include <linux/pkt_sched.h>
>  #include <net/net_namespace.h>
>  #include <net/llc.h>
>  #include <net/llc_pdu.h>
> @@ -40,6 +41,7 @@ static void br_send_bpdu(struct net_brid
>  
>  	skb->dev = p->dev;
>  	skb->protocol = htons(ETH_P_802_2);
> +	skb->priority = TC_PRIO_CONTROL;
>  
>  	skb_reserve(skb, LLC_RESERVE);
>  	memcpy(__skb_put(skb, length), data, length);
> --

I wonder if we should not use the same for ARP packets, as some bonding
modes depend on them as well.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html