netdev - Re: [PATCH] ip.7: Improve explanation about calling listen or connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130211175000.GG31579@obelix.rh>
Date:	Mon, 11 Feb 2013 15:50:00 -0200
From:	Flavio Leitner <fbl@...hat.com>
To:	"Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
Cc:	Peter Schiffer <pschiffe@...hat.com>, linux-man@...r.kernel.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ip.7: Improve explanation about calling listen or connect

On Sun, Feb 10, 2013 at 03:00:03AM +0100, Michael Kerrisk (man-pages) wrote:
> On Wed, Jun 6, 2012 at 4:44 PM, Flavio Leitner <fbl@...hat.com> wrote:
> >
> > Hi,
> >
> > Could someone tell me what's the patch current state?
> > It has been a month already with no feedback.
> > thanks,
> > fbl
> 
> Following up, long after the fact.
> 
> Flavio, I had no time pack then to review this patch... One problem
> is, you never gave any rationle for the change ("Improve explanation
> of..." is not a rationale -- I need to know *why* you think the
> changes are needed.)

Because the current explanation is not detailed enough and/or the way
it is written may lead to a wrong interpretation, specially for non-English
users.  Therefore, it should be improved adding supporting details
and a better writing to clarify each case.

The patch adds the missing details and clarifies each use case.

Thanks,
fbl

> 
> Thanks,
> 
> Michael
> 
> 
> > On Fri, 25 May 2012 13:02:48 +0200
> > Peter Schiffer <pschiffe@...hat.com> wrote:
> >
> >> Hi Michael,
> >>
> >> do you have any comments for this update? Or do you need some supporting
> >> info?
> >>
> >> peter
> >>
> >> On 05/09/2012 02:30 PM, Flavio Leitner wrote:
> >> > Signed-off-by: Flavio Leitner<fbl@...hat.com>
> >> > ---
> >> >   man7/ip.7 |   15 +++++++++------
> >> >   1 files changed, 9 insertions(+), 6 deletions(-)
> >> >
> >> > diff --git a/man7/ip.7 b/man7/ip.7
> >> > index 9f560df..84fe32d 100644
> >> > --- a/man7/ip.7
> >> > +++ b/man7/ip.7
> >> > @@ -69,12 +69,11 @@ For
> >> >   you may specify a valid IANA IP protocol defined in
> >> >   RFC\ 1700 assigned numbers.
> >> >   .PP
> >> > -.\" FIXME ip current does an autobind in listen, but I'm not sure
> >> > -.\" if that should be documented.
> >> >   When a process wants to receive new incoming packets or connections, it
> >> >   should bind a socket to a local interface address using
> >> >   .BR bind (2).
> >> > -Only one IP socket may be bound to any given local (address, port) pair.
> >> > +In this case, only one IP socket may be bound to any given local
> >> > +(address, port) pair.
> >> >   When
> >> >   .B INADDR_ANY
> >> >   is specified in the bind call, the socket will be bound to
> >> > @@ -82,10 +81,14 @@ is specified in the bind call, the socket will be bound to
> >> >   local interfaces.
> >> >   When
> >> >   .BR listen (2)
> >> > -or
> >> > +is called on an unbound socket, the socket is automatically bound
> >> > +to a random free port with the local address set to
> >> > +.BR INADDR_ANY .
> >> > +When
> >> >   .BR connect (2)
> >> > -are called on an unbound socket, it is automatically bound to a
> >> > -random free port with the local address set to
> >> > +is called on an unbound socket, the socket is automatically bound
> >> > +to a random free port or an usable shared port with the local address
> >> > +set to
> >> >   .BR INADDR_ANY .
> >> >
> >> >   A TCP local socket address that has been bound is unavailable for
> >
> 
> 
> 
> -- 
> Michael Kerrisk
> Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
> Author of "The Linux Programming Interface"; http://man7.org/tlpi/
> 

-- 
fbl
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html