netdev - Re: [patch net-next RFC] tbf: handle gso skbs properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1360942238.19353.6.camel@edumazet-glaptop>
Date:	Fri, 15 Feb 2013 07:30:38 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	jhs@...atatu.com, kuznet@....inr.ac.ru, j.vimal@...il.com
Subject: Re: [patch net-next RFC] tbf: handle gso skbs properly

On Fri, 2013-02-15 at 13:44 +0100, Jiri Pirko wrote:

> +	segs = skb_gso_segment(skb, 0);

Try to find out how to avoid a full copy, if the device is SG capable.

maybe using 
	segs = skb_gso_segment(skb,
			netif_skb_features(skb) & ~NETIF_F_GSO_MASK);

Or something like that...

> +	if (IS_ERR(segs) || !segs)
> +		return false;
> +	__skb_unlink(skb, &qdisc->q);
> +	kfree_skb(skb);

consume_skb() would be nice here.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html