netdev - Re: [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHXqBFKEetEKjBDYjyJ8hWMBz4-H_F+Uz9HLfoaUYzcFxaQYMQ@mail.gmail.com>
Date:	Sat, 16 Feb 2013 12:02:21 +0100
From:	Michał Mirosław <mirqus@...il.com>
To:	Pravin B Shelar <pshelar@...ira.com>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, jesse@...ira.com,
	stephen@...workplumber.org
Subject: Re: [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO.

2013/2/16 Pravin B Shelar <pshelar@...ira.com>:
> Adds generic tunneling TCP segment offloading support for IPv4-UDP
> based tunnels.
> GSO type is added to request this offload for a skb.
> netdev feature NETIF_F_UDP_TUNNEL is added for hardware offloaded
> udp-tunnel support. Currently no device supports this feature,
> software offload is used.
>
> This can be used by tunneling protocols like VXLAN.
>
> CC: Jesse Gross <jesse@...ira.com>
> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ---
>  include/linux/netdev_features.h |    7 ++-
>  include/linux/skbuff.h          |    2 +
>  net/ipv4/af_inet.c              |    6 ++-
>  net/ipv4/tcp.c                  |    1 +
>  net/ipv4/udp.c                  |  113 ++++++++++++++++++++++++++++++---------
>  net/ipv6/ip6_offload.c          |    1 +
>  net/ipv6/udp_offload.c          |   10 +++-
>  7 files changed, 109 insertions(+), 31 deletions(-)
>
> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
> index 3dd3934..6d7c474 100644
> --- a/include/linux/netdev_features.h
> +++ b/include/linux/netdev_features.h
> @@ -42,9 +42,9 @@ enum {
>         NETIF_F_TSO6_BIT,               /* ... TCPv6 segmentation */
>         NETIF_F_FSO_BIT,                /* ... FCoE segmentation */
>         NETIF_F_GSO_GRE_BIT,            /* ... GRE with TSO */
> -       /**/NETIF_F_GSO_LAST,           /* [can't be last bit, see GSO_MASK] */
> -       NETIF_F_GSO_RESERVED2           /* ... free (fill GSO_MASK to 8 bits) */
> -               = NETIF_F_GSO_LAST,
> +       NETIF_F_GSO_UDP_TUNNEL_BIT,     /* ... UDP TUNNEL with TSO */
> +       /**/NETIF_F_GSO_LAST =          /* last bit, see GSO_MASK */
> +               NETIF_F_GSO_UDP_TUNNEL_BIT,
>
>         NETIF_F_FCOE_CRC_BIT,           /* FCoE CRC32 */
>         NETIF_F_SCTP_CSUM_BIT,          /* SCTP checksum offload */
> @@ -103,6 +103,7 @@ enum {
>  #define NETIF_F_RXFCS          __NETIF_F(RXFCS)
>  #define NETIF_F_RXALL          __NETIF_F(RXALL)
>  #define NETIF_F_GRE_GSO                __NETIF_F(GSO_GRE)
> +#define NETIF_F_UDP_TUNNEL     __NETIF_F(UDP_TUNNEL)

You might want to add it to NETIF_F_GSO_SOFTWARE mask since this
feature has software fallback.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html