netdev - Re: [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2013 17:39:50 -0800
From:	Pravin Shelar <pshelar@...ira.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, edumazet@...gle.com, jesse@...ira.com,
	stephen@...workplumber.org
Subject: Re: [PATCH net-next 3/4] tunneling: Add generic UDP-Tunnel TSO.

On Fri, Feb 15, 2013 at 5:34 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2013-02-15 at 17:06 -0800, Pravin B Shelar wrote:
>
>> +     /* segment inner packet. */
>> +     segs = skb_mac_gso_segment(skb, skb->dev->hw_enc_features);
>> +     if (!segs || IS_ERR(segs))
>> +             goto out;
>> +
>
> It seems that hw_enc_features is 0 for all devices.
>
right.

> We should at least inherit NETIF_F_SG
>
ok.

> (and presumably netdev_fix_features() should not remove NETIF_F_SG if
> CSUM is not supported, as we now copy the data _if_ needed in
> skb_checksum_help())
>
yes, that is useful. I have separate patch to kill this dependency, I
will sent it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html