netdev - Re: [PATCH] bgmac: fix unaligned accesses to network headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACna6ry0DWdnsLv0MLERkg8evYpgzAFvYEJes3Jn71iCPkJVjw@mail.gmail.com>
Date:	Mon, 18 Feb 2013 17:14:25 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] bgmac: fix unaligned accesses to network headers

2013/2/16 Hauke Mehrtens <hauke@...ke-m.de>:
> Without this patch I get many unaligned access warnings per packet,
> this patches fixes them all. This should improve performance ony some
> systems like mips.
>
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/ethernet/broadcom/bgmac.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
> index d341090..f9b1bc8 100644
> --- a/drivers/net/ethernet/broadcom/bgmac.c
> +++ b/drivers/net/ethernet/broadcom/bgmac.c
> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
>                         bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
>                                   ring->start);
>                 } else {
> -                       new_skb = netdev_alloc_skb(bgmac->net_dev, len);
> +                       new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
>                         if (new_skb) {
> +                               skb_reserve(new_skb, 2);

I never understood that code in b44, glad you hit that warnings! ;)

The version with netdev_alloc_skb_ip_align looks much better (no more
magic numbers), b44 should be converted too.

Thanks for your patch!

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html