netdev - Re: [PATCH] bgmac: fix unaligned accesses to network headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <511FD78C.5000805@hauke-m.de>
Date:	Sat, 16 Feb 2013 20:01:32 +0100
From:	Hauke Mehrtens <hauke@...ke-m.de>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	davem@...emloft.net, zajec5@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bgmac: fix unaligned accesses to network headers

On 02/16/2013 07:36 PM, Stephen Hemminger wrote:
> On Sat, 16 Feb 2013 15:32:34 +0100
> Hauke Mehrtens <hauke@...ke-m.de> wrote:
> 
>> Without this patch I get many unaligned access warnings per packet,
>> this patches fixes them all. This should improve performance ony some
>> systems like mips.
>>
>> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
>> ---
>>  drivers/net/ethernet/broadcom/bgmac.c |    3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
>> index d341090..f9b1bc8 100644
>> --- a/drivers/net/ethernet/broadcom/bgmac.c
>> +++ b/drivers/net/ethernet/broadcom/bgmac.c
>> @@ -301,8 +301,9 @@ static int bgmac_dma_rx_read(struct bgmac *bgmac, struct bgmac_dma_ring *ring,
>>  			bgmac_err(bgmac, "Found poisoned packet at slot %d, DMA issue!\n",
>>  				  ring->start);
>>  		} else {
>> -			new_skb = netdev_alloc_skb(bgmac->net_dev, len);
>> +			new_skb = netdev_alloc_skb(bgmac->net_dev, len + 2);
>>  			if (new_skb) {
>> +				skb_reserve(new_skb, 2);
>>  				skb_put(new_skb, len);
>>  				skb_copy_from_linear_data_offset(skb, BGMAC_RX_FRAME_OFFSET,
>>  								 new_skb->data,
> 
> NAK. Use netdev_alloc_skb_ip_align instead. 
> It is less error prone, and handles case of architectures where unaligned is faster.

Thanks for the hint, I will send a better version of this patch.

Hauke
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html