netdev - Re: [PATCH net-next] generalize VXLAN forwarding tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1362090475.15793.51.camel@edumazet-glaptop>
Date:	Thu, 28 Feb 2013 14:27:55 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David L Stevens <dlstevens@...ibm.com>
Cc:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] generalize VXLAN forwarding tables

On Thu, 2013-02-28 at 14:23 -0500, David L Stevens wrote:

> +	/* if there are multiple destinations, send copies */
> +	for (rdst = rdst0->remote_next; rdst; rdst = rdst->remote_next) {
> +		struct sk_buff *skb1;
> +
> +		skb1 = skb_clone(skb, GFP_ATOMIC);
> +		rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc);
> +		if (rc == NETDEV_TX_OK)
> +			rc = rc1;
> +	}
> +
> +	rc1 = vxlan_xmit_one(skb, dev, rdst0, did_rsc);
> +	if (rc == NETDEV_TX_OK)
> +		rc = rc1;
> +	return rc;
> +}


It looks like vxlan_xmit_one() will overwrite header

So skb_clone() is probably not what you wanted ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html