netdev - Re: [PATCH net-next] generalize VXLAN forwarding tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <OF02E8A5C2.4BBAEF8D-ON85257B20.007D6D06-85257B20.007DED1A@us.ibm.com>
Date:	Thu, 28 Feb 2013 17:55:27 -0500
From:	David Stevens <dlstevens@...ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org,
	Stephen Hemminger <shemminger@...tta.com>
Subject: Re: [PATCH net-next] generalize VXLAN forwarding tables

netdev-owner@...r.kernel.org wrote on 02/28/2013 05:27:55 PM:

> From: Eric Dumazet <eric.dumazet@...il.com>

> On Thu, 2013-02-28 at 14:23 -0500, David L Stevens wrote:
> 
> > +   /* if there are multiple destinations, send copies */
> > +   for (rdst = rdst0->remote_next; rdst; rdst = rdst->remote_next) {
> > +      struct sk_buff *skb1;
> > +
> > +      skb1 = skb_clone(skb, GFP_ATOMIC);
> > +      rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc);
> > +      if (rc == NETDEV_TX_OK)
> > +         rc = rc1;
> > +   }
> > +
> > +   rc1 = vxlan_xmit_one(skb, dev, rdst0, did_rsc);
> > +   if (rc == NETDEV_TX_OK)
> > +      rc = rc1;
> > +   return rc;
> > +}
> 
> 
> It looks like vxlan_xmit_one() will overwrite header
> 
> So skb_clone() is probably not what you wanted ?

We're only prepending encapsulation headers, and we
do skb_cow_head() for each of those in vxlan_xmit_one().
This skb should be just the original , unencapsulated
packet which is identical in all copies.

                                                +-DLS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html